NODE_ENV=production fixes and test fixes. #14
Conversation
|
One more thing... I had to remove the type property in the package.json because it was for making this work with ESModules. Unfortunately, when it comes to TypeScript, I'm not aware of a good way to make ESModules work with the way I've configured TypeScript, and so I'm not sure what to do there, other than to leave it out. |
|
Thanks! |
|
Do you want to add a github action that push a release to npm? I will add the secret to the organization settings. |
|
@cryptoquick do you want to join the maintainers of the project? If you do, please read C4: |
|
Sure, just let me know what environment variable you're using. |
|
NPM_TOKEN |
|
As for joining as a maintainer, yes, I'd actually be interested. I'm very excited about ZeroMQ, and I think it could be a really unique and useful experience to develop streaming data patterns in JavaScript projects. I just skimmed the C4, it all sounds very reasonable. Are there other ways the community communicates other than GitHub? |
|
We have a gitter and a mailing list: https://zeromq.org/our-community/ Make sure to not merge your own pull requests, sent you an invite. |
|
By the way, the next step for this library (IMHO) is to follow (zeromq.js)[https://github.com/zeromq/zeromq.js] and move into async/await API instead of EventEmitter. Checkout the following issue: |
Hey, sorry about this, but as I was testing the build, I noticed that
allowSyntheticDefaultImportsis actually what I was going for, even though TypeScript recommendedesModuleInterop, which also impliesallowSyntheticDefaultImports.I also noticed that the tests weren't running anymore with some changes I made earlier, and I worked to get those working again.
Finally, I had to move most of the TypeScript definitions out of devDependencies because they're actually needed in a production build.
By "production build" I mean, doing an npm install with the NODE_ENV=production, to help trim down the size of the Docker image.
I also had to split up the tsconfig, so that the module can be built without jasmine and tests.
Once this is merged, this should be ready to be pushed. I'd suggest maybe increasing the minor version, just to better signal that there are some changes upstream that might warrant further investigation.